Markers
Table of Contents
PdbPgsql.php
| Type | Line | Description |
|---|---|---|
| TODO | 48 | Postgres has a slightly different concept about permissions. |
| TODO | 119 | primary keys? |
| TODO | 358 | // To use CREATE TYPE ENUM ? |
PdbSqlite.php
| Type | Line | Description |
|---|---|---|
| TODO | 130 | something about null. |
QueryException.php
| Type | Line | Description |
|---|---|---|
| TODO | 62 | should probably check the adapter here too. |
| TODO | 78 | // - 25001 and 25002 => TransactionRecursionException |
SqliteFunctions.php
| Type | Line | Description |
|---|---|---|
| TODO | 24 | https://github.com/alphp/strftime |
PdbColumn.php
| Type | Line | Description |
|---|---|---|
| TODO | 67 | Just because ID is autoinc, we shouldn't also enforce it to |
PdbSchema.php
| Type | Line | Description |
|---|---|---|
| TODO | 85 | host the XSD someone public. |
PdbSimpleCondition.php
| Type | Line | Description |
|---|---|---|
| TODO | 151 | This is still a tad expensive because we're building the |
| TODO | 444 | generate preview for nested conditions + queries. |
Pdb.php
| Type | Line | Description |
|---|---|---|
| TODO | 1318 | this never executes? Why does it exist? |
| TODO | 1374 | this never executes? Why does it exist? |
| TODO | 1669 | At least for SELECT, everything else though? |
PdbConfig.php
| Type | Line | Description |
|---|---|---|
| TODO | 499 | would a random string be better? |
PdbHelpers.php
| Type | Line | Description |
|---|---|---|
| TODO | 20 | Find a better home for these. |
| TODO | 572 | support for fractional seconds. |
PdbParser.php
| Type | Line | Description |
|---|---|---|
| TODO | 221 | I guess we should freak if there's more than one. |
| TODO | 239 | Hey, do other DBs require the FK to be an index? |
PdbSync.php
| Type | Line | Description |
|---|---|---|
| TODO | 229 | Super naive. Total hack. Do better. |
| TODO | 257 | this may change, some DBs must create indexes separately. |
| TODO | 510 | can we detect this behaviour for MySQL? |
| TODO | 591 | SQLite inline indexes can only be created with the column spec. |
| TODO | 894 | Is there a reason we don't do this automatically? |
CsvExport.php
| Type | Line | Description |
|---|---|---|
| TODO | 21 | Tests! |
| TODO | 21 | Option for no headers. |
CsvImport.php
| Type | Line | Description |
|---|---|---|
| TODO | 20 | Tests! |
| TODO | 20 | Option for no headers. |
Secrets.php
| Type | Line | Description |
|---|---|---|
| TODO | 364 | ...what if it's not? |
ShellOutput.php
| Type | Line | Description |
|---|---|---|
| TODO | 296 | This relies on the process to have registered pipes. |
Time.php
| Type | Line | Description |
|---|---|---|
| TODO | 246 | This seems wrong for pass-through objects. |
Url.php
| Type | Line | Description |
|---|---|---|
| TODO | 334 | remove this. I hate it. |
VirtualMethodsTrait.php
| Type | Line | Description |
|---|---|---|
| TODO | 22 | Test this. |
CredisAdapter.php
| Type | Line | Description |
|---|---|---|
| TODO | 331 | Uhh.. does getset actually work here? |
| TODO | 625 | it's not a timeout though. |
PhpRedisAdapter.php
| Type | Line | Description |
|---|---|---|
| TODO | 335 | Uhh.. does getset actually work here? |
RdbHelperTrait.php
| Type | Line | Description |
|---|---|---|
| TODO | 289 | other flags. |
RdbLock.php
| Type | Line | Description |
|---|---|---|
| TODO | 119 | It'd be cool if this were a little more atomic. Cue lua support. |
Router.php
| Type | Line | Description |
|---|---|---|
| TODO | 216 | or throw an error..? |
| TODO | 639 | I'm not sure about always having this slash here.. |
RouterConfig.php
| Type | Line | Description |
|---|---|---|
| TODO | 146 | Should this throw instead? |
PageAdminController.php
| Type | Line | Description |
|---|---|---|
| TODO | 385 | should this be a boolean cast/check? |
| TODO | 440 | should this be a boolean cast/check? |
| TODO | 1585 | should these be a boolean cast/check? |
PerRecordPermissionAdminController.php
| Type | Line | Description |
|---|---|---|
| TODO | 59 | this is from an external module - it should instead use getContentPermissionGroups() |
AdminAjaxController.php
| Type | Line | Description |
|---|---|---|
| TODO | 117 | one day |
| TODO | 464 | import images |
AdminController.php
| Type | Line | Description |
|---|---|---|
| TODO | 124 | should not all modules load their admin in CLI? |
| TODO | 125 | otherwise controllers can't be loaded? is that ok..? |
| TODO | 2139 | this should use translations. |
| TODO | 2246 | this should only permit shorthands but I'm fairly sure we've |
ContentSubscribeController.php
| Type | Line | Description |
|---|---|---|
| TODO | 181 | should this be per subscription or should be store when it last ran? |
Controller.php
| Type | Line | Description |
|---|---|---|
| TODO | 494 | this needs to use an interface/abstract/trait. |
| TODO | 551 | this needs to use an interface/abstract/trait. |
| TODO | 737 | this needs to use an interface/abstract/trait. |
DbToolsController.php
| Type | Line | Description |
|---|---|---|
| TODO | 179 | but does it need admin_load for modules? |
FileUploadController.php
| Type | Line | Description |
|---|---|---|
| TODO | 212 | implement rate-limiting and other anti-spam measures |
PageController.php
| Type | Line | Description |
|---|---|---|
| TODO | 551 | add history of approval |
| TODO | 574 | add history of denial |
WorkerJobController.php
| Type | Line | Description |
|---|---|---|
| TODO | 129 | This should be always enabled after we sort out logrotate. |
Kohana.php
| Type | Line | Description |
|---|---|---|
| TODO | 462 | should we throw if the file doesn't exist? |
| TODO | 1248 | should we use STDOUT? |
AdminPerms.php
| Type | Line | Description |
|---|---|---|
| TODO | 424 | home_page is non-core. |
| TODO | 445 | 'user' modules is non-core. |
AdminSeo.php
| Type | Line | Description |
|---|---|---|
| TODO | 212 | Calculate and return actual word count per section |
Cors.php
| Type | Line | Description |
|---|---|---|
| TODO | 166 | Validate origins here. |
Fb.php
| Type | Line | Description |
|---|---|---|
| TODO | 862 | Use a generic method to generate the SELECT tag and its attributes |
| TODO | 1304 | Mobile to use a "date" field instead, for native UI |
| TODO | 1558 | Mobile to use a "datetime-local" field instead, for native UI |
| TODO | 1601 | Does this need validation exceptions? I.e. min/max attributes invalid? |
FilesBackendS3.php
| Type | Line | Description |
|---|---|---|
| TODO | 312 | Is this too granular? |
| TODO | 599 | Something with the S3 file? |
| TODO | 793 | Is this too granular? |
| TODO | 855 | Something with the S3 file? |
FileStream.php
| Type | Line | Description |
|---|---|---|
| TODO | 172 | Could do more here. |
FileTransform.php
| Type | Line | Description |
|---|---|---|
| TODO | 404 | This is too messy |
JsonForm.php
| Type | Line | Description |
|---|---|---|
| TODO | 511 | add to errors. |
Rdb.php
| Type | Line | Description |
|---|---|---|
| TODO | 37 | Remove this. This is fixed in v1.20.10. |
Request.php
| Type | Line | Description |
|---|---|---|
| TODO | 196 | this only supports ipv4. |
| TODO | 544 | This is incredible naive. It doesn't handle quoted values. (is that a thing?) |
| TODO | 741 | Does multipart have more headers per key? |
| TODO | 755 | Should this just be $_POST? |
RichTextSanitiser.php
| Type | Line | Description |
|---|---|---|
| TODO | 310 | this needs to handle subsites and all that mess |
| TODO | 324 | style attributes are tricky; I can force a browser to fetch a remote resource with them |
Security.php
| Type | Line | Description |
|---|---|---|
| TODO | 74 | Can we use sodium? |
SproutExtension.php
| Type | Line | Description |
|---|---|---|
| TODO | 83 | Should update the core ones eventually. |
SproutVariable.php
| Type | Line | Description |
|---|---|---|
| TODO | 241 | Is this too aggressive? |
WorkerCtrl.php
| Type | Line | Description |
|---|---|---|
| TODO | 282 | Why and what does this do? |
| TODO | 356 | Other frameworks like to use an environment variable to help |
WorkerLinkChecker.php
| Type | Line | Description |
|---|---|---|
| TODO | 209 | Try to think up a way this could be made to work. |
| TODO | 216 | This whole things should be using HttpReq but I'm in a rush rn. |
WorkerQueue.php
| Type | Line | Description |
|---|---|---|
| TODO | 242 | in future, some more advanced options: |
| TODO | 278 | Why and what does this do? |
CategoryModel.php
| Type | Line | Description |
|---|---|---|
| TODO | 131 | Add shared transaction support. |
ExceptionLogModel.php
| Type | Line | Description |
|---|---|---|
| TODO | 137 | get error message from the validator. |
| TODO | 201 | this should be upstreamed into kbphp. |
FileModel.php
| Type | Line | Description |
|---|---|---|
| TODO | 158 | nested or shared transactions support in kbpdb. |
| TODO | 209 | is from_path required or not?? |
| TODO | 229 | nested or shared transactions support in kbpdb |